Review Request 119291: Use an <input type="search"> for the search box.

Alex Merry alex.merry at kde.org
Tue Jul 15 18:14:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119291/#review62407
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On July 15, 2014, 8:29 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119291/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 8:29 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Use an `<input>` with a proper type and a placeholder: this allows the platform to style it differently if necessary, and the use of the placeholder attribute lets us to get rid of the custom script to clean up its value.
> 
> 
> Diffs
> -----
> 
>   src/kapidox/data/templates/base.html 10f8aa6dae14e0ad6e649bdb28fcba81b7d39341 
> 
> Diff: https://git.reviewboard.kde.org/r/119291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140715/82e7a0f0/attachment.html>


More information about the Kde-frameworks-devel mailing list