Review Request 119242: Fix QExplicitlySharedDataPointer usage

Milian Wolff mail at milianw.de
Tue Jul 15 14:30:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119242/#review62402
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On July 12, 2014, 9:43 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119242/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 9:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix QExplicitlySharedDataPointer usage
> 
> One of the constructors of QExplicitlySharedDataPointer got disabled in
> Qt 5.4 due to being to permissive.
> 
> Also see:
> http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/
> 
> 
> Diffs
> -----
> 
>   src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a 
> 
> Diff: https://git.reviewboard.kde.org/r/119242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140715/1d04455e/attachment.html>


More information about the Kde-frameworks-devel mailing list