Review Request 119284: Semantically correct uiReady

Marco Martin notmart at gmail.com
Tue Jul 15 08:19:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119284/
-----------------------------------------------------------

(Updated July 15, 2014, 8:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

The last changes in how uiReady is assigned actually just broke it (it was just immediately true)
now that there is an autotest is easier to test in various corner cases, and especially (where it broke) whether is the containment  or the applets it contains that are the faster loading the contents


Diffs
-----

  src/plasma/private/containment_p.cpp 018abfe 
  src/plasma/private/containment_p.h e4b76be 
  src/plasma/corona.cpp 9a6b601 
  src/plasma/private/applet_p.cpp b6bebe5 
  src/plasma/containment.cpp 35bfbfc 
  autotests/plasma-test-appletsrc 457108e 
  autotests/coronatest.h 2e5b9c3 
  autotests/coronatest.cpp 8e74c83 

Diff: https://git.reviewboard.kde.org/r/119284/diff/


Testing
-------

plasmashell still works.
but the autotests now do pass


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140715/0fc92f93/attachment.html>


More information about the Kde-frameworks-devel mailing list