Review Request 119270: Autotest for corona restore and behavior

[Marco Martin]

> On July 14, 2014, 5:26 p.m., David Edmundson wrote:
> > autotests/coronatest.cpp, line 95
> > <https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95>
> >
> >     it might make sense to make all of this in init()/cleanup() rather than initTestCase()
> >     that way each test gets it's own SimpleCorona and you don't have to worry about each test cleaning up after itself.

you mean calling it from each test or qtest does that automatically?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62312
-----------------------------------------------------------


On July 14, 2014, 5:22 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119270/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 5:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is a simple autotest for loading a simple corona, checking that the uiready signals are emitted, that adding and removing applets work, and the immutability settings do work.
> 
> The test is now passing and pretty basic, if someone can think about any new things to test, please add in the test ;)
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 060132d 
>   autotests/coronatest.h PRE-CREATION 
>   autotests/coronatest.cpp PRE-CREATION 
>   autotests/coronatestresources.qrc PRE-CREATION 
>   autotests/plasma-test-appletsrc PRE-CREATION 
>   src/plasma/corona.cpp e18f081 
>   src/plasma/private/containment_p.cpp f8b4578 
> 
> Diff: https://git.reviewboard.kde.org/r/119270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140714/6788df22/attachment.html>