Review Request 119270: Autotest for corona restore and behavior
Marco Martin
notmart at gmail.com
Mon Jul 14 17:20:49 UTC 2014
> On July 14, 2014, 1:40 p.m., David Edmundson wrote:
> > autotests/coronatest.cpp, line 81
> > <https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line81>
> >
> > why is this commented out?
copy and paste, i guess both using it a or not is fine, since it's waiting for the kbuildsycoca process to finish, but i reenabled it to be extra sure
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62294
-----------------------------------------------------------
On July 14, 2014, 12:30 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119270/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 12:30 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This is a simple autotest for loading a simple corona, checking that the uiready signals are emitted, that adding and removing applets work, and the immutability settings do work.
>
> The test is now passing and pretty basic, if someone can think about any new things to test, please add in the test ;)
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 060132d
> autotests/coronatest.h PRE-CREATION
> autotests/coronatest.cpp PRE-CREATION
> autotests/coronatestresources.qrc PRE-CREATION
> autotests/plasma-test-appletsrc PRE-CREATION
> src/plasma/corona.cpp e18f081
> src/plasma/private/containment_p.cpp f8b4578
>
> Diff: https://git.reviewboard.kde.org/r/119270/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140714/5d2e5ef1/attachment.html>
More information about the Kde-frameworks-devel
mailing list