Review Request 119155: Make the desktop containment respect minimum sizes

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119155/
-----------------------------------------------------------

(Updated July 14, 2014, 1:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-desktop


Description
-------

make the applets respect the minimum size, specified by applets, with  the following logic:
if there is a preferred representation, enforce its minimum size,
if there is a compact representation, enforce its minimum size.

note: the minimum size of the full representation is not enforced if it's not the preferred one, because it must still be possible to switch to the compact one.

this would fix bugs such as
https://bugs.kde.org/show_bug.cgi?id=337069


Diffs
-----

  containments/desktop/package/contents/ui/AppletAppearance.qml 9149f48 

Diff: https://git.reviewboard.kde.org/r/119155/diff/


Testing
-------

* even if the property reading is buried down in a function, property binding still works correctly.

* if the minimum size grows, it may happen the case of overlapping applets, thing that was avoideed with care by the new layout engine. This may be a blocker in shipping it for 5.0


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140714/6158e5b6/attachment.html>