Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

[Martin Gräßlin]

> On July 14, 2014, 11:35 a.m., Martin Gräßlin wrote:
> > src/kwindowsystem_x11.cpp, line 596
> > <https://git.reviewboard.kde.org/r/119267/diff/1/?file=290051#file290051line596>
> >
> >     NET::WMDesktop looks wrong to me. This means: please add a unit test.
> 
> Ivan Čukić wrote:
>     I guess it can be 0 instead? The setter method does not rely on the info's retrieved properties.

yeah should be 0 then.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119267/#review62275
-----------------------------------------------------------


On July 14, 2014, 11:06 a.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119267/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Currently, the library only has the method for retrieving a list of activities a window belongs to.
> 
> This is adding a method which provides changing the list of activities for a window.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem.h 0b58e71 
>   src/kwindowsystem.cpp fb59603 
>   src/kwindowsystem_p.h 8861844 
>   src/kwindowsystem_p_x11.h 9baa6ae 
>   src/kwindowsystem_x11.cpp 2016820 
>   src/netwm.h 2d812a7 
>   src/netwm.cpp 1daad1e 
> 
> Diff: https://git.reviewboard.kde.org/r/119267/diff/
> 
> 
> Testing
> -------
> 
> Yes :)
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140714/d58dfce0/attachment.html>