Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.
David Faure
faure at kde.org
Sun Jul 13 22:36:56 UTC 2014
> On July 13, 2014, 11:20 a.m., David Faure wrote:
> > Which version of Qt are you using? On which OS, with which compiler?
> >
> > (I think the issue is Qt 5.2 vs 5.3, let's see...)
>
> Andreas Xavier wrote:
> Thank you for the quick response.
>
> I am using Fedora 20, linux 3.14.9, gcc 4.8.3, and Qt 5.2.
>
> So I take it that if I compile Qt5.3 from source QBasicAtomicInt has the implicit constructors to/from int?
Yes. However, we advertise Qt 5.2 compatibility, so this patch should actually go in.
I just wanted to make sure this was the issue.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119257/#review62246
-----------------------------------------------------------
On July 13, 2014, 4:11 p.m., Andreas Xavier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119257/
> -----------------------------------------------------------
>
> (Updated July 13, 2014, 4:11 p.m.)
>
>
> Review request for KDE Frameworks and Matthew Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> While building frameworks following https://community.kde.org/Frameworks/Building/Details,
> I was unable to compile kconfig because QBasicAtomicInt is being treated as an int. This patch fixes that problem.
>
>
> Diffs
> -----
>
> src/core/kconfig.cpp 14a5d39
>
> Diff: https://git.reviewboard.kde.org/r/119257/diff/
>
>
> Testing
> -------
>
> Compiled successfully.
>
>
> Thanks,
>
> Andreas Xavier
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140713/2ae8955c/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list