Review Request 119258: kcoreaddons: Fix ecm_generate_headers don't accumulate and only kaboutdata.h is exported.

[Andreas Xavier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119258/
-----------------------------------------------------------

(Updated July 13, 2014, 4:11 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Michael Pyne.


Repository: kcoreaddons


Description
-------

While bulding frameworks following https://community.kde.org/Frameworks/Building/Details, I was unable to use kcoreaddons in anything because the only header that was exported was kaboutdata.  I think that the problem is that ecm_generate_headers will not accumulate the list of required_headers on the same variable as the initial variables.  In the patch I created a new variable KCoreAddons_HEADERSout to fix this problem.

I may also have incorrectly configured ecm, in which case this patch will not be useful.


Diffs
-----

  src/lib/CMakeLists.txt 26eb5a1 

Diff: https://git.reviewboard.kde.org/r/119258/diff/


Testing
-------

Compiled and then linked with kauth, which previously couldn't find kjob.h.


Thanks,

Andreas Xavier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140713/a898f9b1/attachment.html>