Review Request 119259: kservice: Fix typo in autotests/nsaplugin.cpp nsapluginfa to nsaplugin

Alex Merry alex.merry at kde.org
Sun Jul 13 11:58:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119259/#review62250
-----------------------------------------------------------

Ship it!


A note for the future: your "Testing done" field suggests you haven't tried running the tests. Running "make test" to check your changes is always a good idea. I applied your patch to my checkout, and they ran fine, though, so you can ship it.

- Alex Merry


On July 13, 2014, 11:19 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119259/
> -----------------------------------------------------------
> 
> (Updated July 13, 2014, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> When compiling framworks following https://community.kde.org/Frameworks/Building/Details, I was unable to compile kservice.  I think that the problem was the typo nsapluginfa for nsaplugin.  This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   autotests/nsaplugin.cpp 48aeaf4 
> 
> Diff: https://git.reviewboard.kde.org/r/119259/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140713/7a859198/attachment.html>


More information about the Kde-frameworks-devel mailing list