Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

[Cristian Oneț]

> On Iulie 12, 2014, 7:33 p.m., David Faure wrote:
> > Looks good.
> > 
> > Grepping for S_ISDIR shows that kdelibs4support has some more (but no other framework does).

The rest is in code the is not compiled on Windows or at least MSVC.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/#review62213
-----------------------------------------------------------


On Iulie 12, 2014, 7:25 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119248/
> -----------------------------------------------------------
> 
> (Updated Iulie 12, 2014, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt.
> 
> Here is the compiler output:
> 
> kshorturifilter.cpp
> q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found
> q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found
> 
> 
> Diffs
> -----
> 
>   src/urifilters/shorturi/kshorturifilter.cpp 8341829 
> 
> Diff: https://git.reviewboard.kde.org/r/119248/diff/
> 
> 
> Testing
> -------
> 
> Build with msvc2013 on Windows and gcc-4.8.3 on Linux.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/1ce0374e/attachment.html>