Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119164/#review62218
-----------------------------------------------------------

Ship it!


I checked this patch and the rc files do land in share/kxmlgui5/khtml/ as intended.

- Marko Käning


On July 7, 2014, 9:17 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119164/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 9:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell, Marko Käning, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)
> 
> This removes the need to version the file themselves, so revert that.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt fe4f49e5799f6b8781eebb217c49b9171600e2f3 
>   src/khtml_part.cpp d7dcb92619d1ba69f015b3a48d9b352f40241196 
> 
> Diff: https://git.reviewboard.kde.org/r/119164/diff/
> 
> 
> Testing
> -------
> 
> testkhtml still has menus (even after removing the old files)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/e1e5425a/attachment.html>