Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

Cristian Oneț onet.cristian at gmail.com
Sat Jul 12 19:30:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/
-----------------------------------------------------------

(Updated Iulie 12, 2014, 7:30 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
-------

post-review keeps removing kdewin :).


Repository: kcoreaddons


Description
-------

On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage.

Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/


Diffs
-----

  src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 

Diff: https://git.reviewboard.kde.org/r/119251/diff/


Testing
-------

Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/40ab48e6/attachment.html>


More information about the Kde-frameworks-devel mailing list