Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

[Cristian Oneț]

> On Iulie 12, 2014, 7:26 p.m., Alex Merry wrote:
> > src/lib/kaboutdata.h, line 38
> > <https://git.reviewboard.kde.org/r/119251/diff/1/?file=289784#file289784line38>
> >
> >     Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd.

You're right, sorry about that, but it do works both ways :).


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/#review62209
-----------------------------------------------------------


On Iulie 12, 2014, 7:30 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119251/
> -----------------------------------------------------------
> 
> (Updated Iulie 12, 2014, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage.
> 
> Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 
> 
> Diff: https://git.reviewboard.kde.org/r/119251/diff/
> 
> 
> Testing
> -------
> 
> Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/b7786cb7/attachment-0001.html>