Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/
-----------------------------------------------------------

(Updated Iulie 12, 2014, 7:09 p.m.)


Review request for KDE Frameworks and kdewin.


Repository: kdelibs4support


Description
-------

Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them.

That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them).

Here is a list of issues:
1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry'
2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage
3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface
4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885
5. KEditListBox::CustomEditor linker error caused by missing export


Diffs
-----

  src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd 
  src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 
  src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 
  src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f 
  tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 

Diff: https://git.reviewboard.kde.org/r/119249/diff/


Testing
-------

Build with msvc2013 on Windows and gcc-4.8.3 on Linux.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/564d70d5/attachment.html>