Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/
-----------------------------------------------------------

(Updated Iulie 12, 2014, 2:20 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
-------

Add kdewin to the groups.


Repository: kio


Description
-------

IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt.

Here is the compiler output:

kshorturifilter.cpp
q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found
q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found


Diffs
-----

  src/urifilters/shorturi/kshorturifilter.cpp 8341829 

Diff: https://git.reviewboard.kde.org/r/119248/diff/


Testing
-------

Build with msvc2013 on Windows and gcc-4.8.3 on Linux.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/6faaaa1d/attachment.html>