Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119247/
-----------------------------------------------------------

(Updated Iulie 12, 2014, 2:20 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
-------

Add kdewin to the groups.


Repository: kio


Description
-------

The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup.

Here is the compiler output:

q:\kio\src\core\udsentry.cpp(72) : error C2440: '<function-style-cast>' : cannot convert from 'const short' to 'KUser'
        No constructor could take the source type, or constructor overload resolution was ambiguous
q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union
q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments
q:\kio\src\core\udsentry.cpp(73) : error C2440: '<function-style-cast>' : cannot convert from 'const short' to 'KUserGroup'
        No constructor could take the source type, or constructor overload resolution was ambiguous
q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union
q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments


Diffs
-----

  src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc 

Diff: https://git.reviewboard.kde.org/r/119247/diff/


Testing
-------

Build with msvc2013 on Windows and gcc-4.8.3 on Linux.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140712/e1630f1d/attachment.html>