Review Request 119111: Make FindGettext compatible with the one provided by CMake

[Aleix Pol]

On Tuesday 08 July 2014 21:51:15 Albert Astals Cid wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119111/#review61935
> -----------------------------------------------------------
> 
> 
> I know i'm late, but if CMake provides one, can't we just kill ours?
> 
> - Albert Astals Cid
> 
> On jul. 7, 2014, 5:27 p.m., Alex Merry wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/119111/
> > -----------------------------------------------------------
> > 
> > (Updated jul. 7, 2014, 5:27 p.m.)
> > 
> > 
> > Review request for KDE Frameworks and Jonathan Riddell.
> > 
> > 
> > Repository: kdelibs4support
> > 
> > 
> > Description
> > -------
> > 
> > This version will accept the old GETTEXT_PROCESS_PO_FILES() syntax (no
> > PO_FILES argument), but will also accept the new syntax required by
> > CMake's version of this file. It will also warn when PO_FILES is not
> > given.
> > 
> > 
> > Diffs
> > -----
> > 
> >   cmake/modules/FindGettext.cmake 
91e88f7e00ac52539066e71eeffb7df6c2148196
> > 
> > Diff: https://git.reviewboard.kde.org/r/119111/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > None whatsoever: Jonathan, you know where this isssue has been seen, can
> > you test?
> > 
> > 
> > Thanks,
> > 
> > Alex Merry

Yes, we should, that's why I asked somewhere if they're compatible...?

At least we should deprecate it.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140709/cc9a2157/attachment.html>