Review Request 119145: Use qtpaths instead of kf5-confg in startkde

Luca Beltrame lbeltrame at kde.org
Sun Jul 6 13:19:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119145/
-----------------------------------------------------------

(Updated Lug. 6, 2014, 1:19 p.m.)


Review request for KDE Frameworks, Plasma and David Faure.


Changes
-------

Whoops, use ConfigLocation (there's no such thing as GenericConfigLocation) and update "libpath" to be "scriptpath" so that it's clear what it does.


Bugs: 333793
    https://bugs.kde.org/show_bug.cgi?id=333793


Repository: plasma-workspace


Description (updated)
-------

Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found.

This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome.

[1] http://lists.kde.org/?t=140464151200002&r=1&w=2


Diffs (updated)
-----

  startkde/startkde.cmake 24610f4 

Diff: https://git.reviewboard.kde.org/r/119145/diff/


Testing
-------


Thanks,

Luca Beltrame

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140706/0b42a0ec/attachment.html>


More information about the Kde-frameworks-devel mailing list