Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

[Alex Merry]

> On July 6, 2014, 12:52 p.m., Alex Merry wrote:
> > A little concerned that there are no documentation changes as part of this patch. Is this stuff noted in the apidocs?
> > 
> > Also, I assume that not changing the behaviour of setXMLFile is a deliberate decision. What's the reasoning? That should probably be noted in a comment or in the apidocs.
> 
> David Faure wrote:
>     You're right that this could be documented in the kxmlgui apidocs. Note that (AFAICS) the old install location wasn't documented either.
>     
>     I don't understand your second paragraph though. This patch DOES change the behaviour of setXMLFile: it looks in kxmlgui5/ first.

Oh, yes, so it does. I was assuming it didn't from not properly reading your "Testing Done" section about porting konsole. Now I see why the old call wouldn't work with the new install location. Forget that para, then (well, except that the porting trap should be noted in the docs, of course).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119142/#review61693
-----------------------------------------------------------


On July 6, 2014, 9:47 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119142/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 9:47 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Kevin Ottens.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc
> 
> The old files (DATADIR/component_name/file.rc) can still be loaded,
> and a runtime warning is shown in such a case, telling people to install
> into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d)
> 
> This keeps DATADIR slightly cleaner, getting rid of many application subdirs
> that would just contain a rc file. Some people seem to care about the cleanliness
> of their DATADIR :-)
> 
> 
> Diffs
> -----
> 
>   src/kedittoolbar.cpp 32512e9caccdbee1b07ff791fbecdcc817ca5726 
>   src/kxmlguiclient.cpp f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d 
>   src/kxmlguifactory.cpp aa657bcc24a949f4350975609f19fae8b6c9a4f0 
> 
> Diff: https://git.reviewboard.kde.org/r/119142/diff/
> 
> 
> Testing
> -------
> 
> Running kwrite unmodified -> works, with runtime warning
> Porting kwrite to KXMLGUI_INSTALL_DIR -> works, runtime warning is gone
> 
> I also did the same with konsole, special case since it called setXMLFile("konsole/partui.rc"), had to be ported to setComponentName("konsole") + setXMLFile("partui.rc") while porting to KXMLGUI_INSTALL_DIR. This patch is still SC/BC, it's just a porting trap -- that affects none of the other existing kf5-based apps though.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140706/a497f06e/attachment.html>