Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

[David Faure]

> On July 5, 2014, 9:44 p.m., Christoph Feck wrote:
> > Alternatively, the button would get disabled, and the tooltip explains why.

Yes, I thought about that too - but it's really not like this button is an important part of the KMimeTypeChooser functionality. You can use it all "readonly" (select a mimetype, which is the main goal of the dialog). Creating from there is just a shortcut.

Just like you wouldn't be able to find the filetypes KCM either, on such a system -- it would be just not there, rather than visible but disabled.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119126/#review61674
-----------------------------------------------------------


On July 5, 2014, 10:30 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119126/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 10:30 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Jonathan Riddell.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.
> 
> 
> Diffs
> -----
> 
>   src/kmimetypechooser.cpp 3caf6fa95ace370fc14721fbfa7eb1aa782489a0 
> 
> Diff: https://git.reviewboard.kde.org/r/119126/diff/
> 
> 
> Testing
> -------
> 
> ./tests/kmimetypechoosertest, before and after removing the keditfiletype5 binary.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140705/e8d8157e/attachment.html>