Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.
David Faure
faure at kde.org
Sat Jul 5 17:59:14 UTC 2014
> On July 5, 2014, 11:28 a.m., Mark Gaiser wrote:
> > src/kmimetypechooser.cpp, line 64
> > <https://git.reviewboard.kde.org/r/119126/diff/1/?file=287325#file287325line64>
> >
> > static const QString s_keditfiletypeExecutable = QStringLiteral("keditfiletype5");
> >
> > Then you can just use s_keditfiletypeExecutable directly instead of QString::fromLatin1... which makes the arguments a bit shorter
Please read https://git.reviewboard.kde.org/r/119079/#comment42878
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119126/#review61641
-----------------------------------------------------------
On July 5, 2014, 10:30 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119126/
> -----------------------------------------------------------
>
> (Updated July 5, 2014, 10:30 a.m.)
>
>
> Review request for KDE Frameworks, Christoph Feck and Jonathan Riddell.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.
>
>
> Diffs
> -----
>
> src/kmimetypechooser.cpp 3caf6fa95ace370fc14721fbfa7eb1aa782489a0
>
> Diff: https://git.reviewboard.kde.org/r/119126/diff/
>
>
> Testing
> -------
>
> ./tests/kmimetypechoosertest, before and after removing the keditfiletype5 binary.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140705/59279d18/attachment.html>
More information about the Kde-frameworks-devel
mailing list