Review Request 119111: Make FindGettext compatible with the one provided by CMake

Heiko Becker heirecka at exherbo.org
Fri Jul 4 11:55:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119111/#review61601
-----------------------------------------------------------



cmake/modules/FindGettext.cmake
<https://git.reviewboard.kde.org/r/119111/#comment42863>

    This also removes the first po_file argument resulting in no installed translations at all if a single po file per language directory is shipped.
    
    After removing the " 1" I've successfully built and installed systemsettings-4.98.0


- Heiko Becker


On July 4, 2014, 10:12 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119111/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 10:12 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Jonathan Riddell.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> This version will accept the old GETTEXT_PROCESS_PO_FILES() syntax (no
> PO_FILES argument), but will also accept the new syntax required by
> CMake's version of this file. It will also warn when PO_FILES is not
> given.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindGettext.cmake 91e88f7e00ac52539066e71eeffb7df6c2148196 
> 
> Diff: https://git.reviewboard.kde.org/r/119111/diff/
> 
> 
> Testing
> -------
> 
> None whatsoever: Jonathan, you know where this isssue has been seen, can you test?
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140704/e1103b5c/attachment.html>


More information about the Kde-frameworks-devel mailing list