kdelibs4support FindGettext

[Alex Merry]

On 04/07/14 10:41, Alex Merry wrote:
> On 04/07/14 10:07, Jonathan Riddell wrote:
>> On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote:
>>> On 03/07/14 22:06, Jonathan Riddell wrote:
>>>> kdelibs4support ships an old copy of FindGettext.cmake.  This is incompatible with the version shipping in cmake and causes some compile failures.  Can I remove it?
>>>
>>> The interfaces of both files look like they should be the same. Do you
>>> have any info about the compile failures?
>>
>> http://techbase.kde.org/Development/ECM_SourceIncompatChanges#FindGettext.cmake
>> "We use the version from CMake now. The syntax of GETTEXT_PROCESS_PO_FILES() changed a bit, it now needs the additional keyword "PO_FILES. "
>>
>> If you add the PO_FILES keyword then the old FindGettext.cmake breaks on GETTEXT_PROCESS_PO_FILES()
> 
> So we could make the old one accept but ignore the PO_FILES keyword
> argument. In fact, we could make it warn when you don't pass it (as it
> will stop working as soon as you remove kdelibs4support from the list of
> packages to find).

See https://git.reviewboard.kde.org/r/119111/