Allow to add a ActionButton in KPageDialog

[laurent Montel]

Le vendredi 4 juillet 2014 08:13:58 Kevin Ottens a écrit :
> On Thursday 03 July 2014 19:50:35 laurent Montel wrote:
> > Hi,
> > During kdepim porting I saw that it was not possible to add a ActionButton
> > as QButtonBox is protected.
> > => we can do it if we create a derived class.
> > But it’s not a very easy method for just add a button.
> > 
> > I would like to add a new method to do it.
> > I created a patch for it.
> > 
> > What do you think about it ?
> > 
> > (Example when we need to add a ActionButton, it’s when we have a old
> > "User1" button).
> 
> Looks OK to me. Will it come with an automated test? We should get serious
> about that in our reviews as well, and I know you've the necessary
> testing-fu to get this simple case properly tested. ;-)

Yes indeed you’re right.
I create a autotest there was not an autotest for it.

It doesn’t look at all kpagedialog class but look at code that I added (and 
initialize state).

Regards.

> Regards.

-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwidgetaddons-add-action-button-with-autotest.diff
Type: text/x-patch
Size: 7012 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140704/e8885ab3/attachment-0001.diff>