Review Request 119058: add a test case for KIconLoader::addAppDir()

David Faure faure at kde.org
Wed Jul 2 14:27:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119058/#review61491
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On July 2, 2014, 9 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119058/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 9 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> when the theme is not complete, KIconLoader::addAppDir may break the fallback to the default themeof icons to the default theme.
> this test case shhows the breakage.
> commenting out addAppDir() makes the test pass.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 798509d 
>   autotests/breeze.theme PRE-CREATION 
>   autotests/kiconloader_unittest.cpp d4ec842 
>   autotests/resources.qrc 33c2510 
> 
> Diff: https://git.reviewboard.kde.org/r/119058/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140702/4eeead75/attachment.html>


More information about the Kde-frameworks-devel mailing list