Review Request 119076: KIconLoader: start by clearing the output variable
David Faure
faure at kde.org
Tue Jul 1 19:07:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119076/
-----------------------------------------------------------
(Updated July 1, 2014, 7:07 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and Christoph Feck.
Repository: kiconthemes
Description
-------
KIconLoader: start by clearing the output variable
in case people only check that and not the returned QIcon.
Diffs
-----
src/kiconloader.cpp 4080a1d295ed442bbcc055b6274d98acdfb8fa4c
Diff: https://git.reviewboard.kde.org/r/119076/diff/
Testing
-------
unittests still pass.
This is mostly for the testcase at https://git.reviewboard.kde.org/r/119058 to make sense.
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/3522d68d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list