Review Request 119074: Fix reading of XDG style semicolon separated lists with escaped '; '

Matthew Dawson matthew at mjdsystems.ca
Tue Jul 1 18:40:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119074/#review61417
-----------------------------------------------------------

Ship it!


Ship It!

- Matthew Dawson


On July 1, 2014, 2:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119074/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Previously the warning "Invalid escape sequence "\;"." would appear and
> "\;" was replaced with just the backslash as is done for all
> unrecognized escape sequences. Keep both characters so that
> readXdgListEntry() works with values containing semicolons
> 
> 
> Diffs
> -----
> 
>   autotests/kdesktopfiletest.cpp b1938b80bd8006b45068613e0c1e7ad980287f34 
>   autotests/kconfigtest.cpp 5f2c798902ea3e8c8207a744ae59f706be2694ed 
>   autotests/kconfigtest.h f2897a8f2497d4d84d292d7fbc30641e4adfeb83 
>   src/core/kconfigini.cpp 5fe4de032c5d42559962c078b988bfcff52c8960 
> 
> Diff: https://git.reviewboard.kde.org/r/119074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/a86c1e0e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list