Review Request 119038: Allow loading KCMs from QT_PLUGIN_PATH subdirectories

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119038/
-----------------------------------------------------------

(Updated July 1, 2014, 3:30 p.m.)


Review request for KDE Frameworks.


Repository: kcmutils


Description
-------

Previously we would crash with an assertion inside libdbus-1 because of
additional / characters in the dbus path if X-KDE-Library in the
.desktop file pointed to a plugin inside a subdirectory of the plugin
path. We now just use the name of the library and strip all leading
directories from the name that is registered in DBus


This would allow moving all kcms into e.g. plugins/kcm5 which would allow
cleaning up the plugins/ directory


Diffs (updated)
-----

  src/kcmoduleproxy.cpp 7596f36e1e26ce080634f3cc0f89e27280423f25 

Diff: https://git.reviewboard.kde.org/r/119038/diff/


Testing
-------

- moved $KF5/lib64/plugins/kcm_clock.so to $KF5/lib64/plugins/kcm5/kcm_clock.so
- changed X-KDE-Library to "kcm5/kcm_clock" in $KF5/share/kservice5/clock.desktop
- ran kbuildsycoca5

"kcmshell5 clock" before this patch -> crash
"kcmshell5 clock" after this patch -> works as expected


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/21a238b7/attachment.html>