Review Request 115415: Allow kpac_proxyscout to be built again
Alex Merry
kde at randomguy3.me.uk
Fri Jan 31 20:53:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/#review48716
-----------------------------------------------------------
Ship it!
- Alex Merry
On Jan. 31, 2014, 5:57 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115415/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 5:57 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> In 03a83c76f29935e8d11bd7f8470bbc72e821dae5, QtScript was removed from the main Qt find_package because it's optional, but it was never readded anywhere. So, kpac_proxyscout would never be built.
>
>
> Diffs
> -----
>
> src/kpac/CMakeLists.txt c3327060bfd6479a008a4ca5e3d2e6f2dc69ceb1
>
> Diff: https://git.reviewboard.kde.org/r/115415/diff/
>
>
> Testing
> -------
>
> It never built, and now it does.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/a5c06f65/attachment.html>
More information about the Kde-frameworks-devel
mailing list