Review Request 115416: Improve knewstuff dependencies
Jeremy Whiting
jpwhiting at kde.org
Fri Jan 31 19:54:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/#review48709
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Jan. 31, 2014, 11:49 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115416/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 11:49 a.m.)
>
>
> Review request for KDE Frameworks and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> - QtDBus and QtNetwork are not used
> - Remove transitive framework dependencies
> - Add missing framework dependencies
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 9df24837f3915c2554d6be9c6be76ebfaee8cdcd
> CMakeLists.txt aeed4d455498cc3ef4a24242b4d2c9c3f69809e3
>
> Diff: https://git.reviewboard.kde.org/r/115416/diff/
>
>
> Testing
> -------
>
> Builds. Inspected CPP and UI includes and runtime links.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/52cd16d9/attachment.html>
More information about the Kde-frameworks-devel
mailing list