Review Request 115336: Change syntax of kservice_desktop_to_json

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115336/#review48705
-----------------------------------------------------------

Ship it!


There was an optional jsonfile argument; I guess you checked nothing was using it?  Because anything that was will be broken by this.

That said, I have no objection to breaking source compatibility of something that hasn't even been released yet, so...

- Alex Merry


On Jan. 27, 2014, 5:20 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115336/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 5:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This makes kservice_desktop_to_json take advantage of new features in CMake 3.0 which makes it possible to generate the .json file at build time rather than configure time. This requires the user to pass the target which depends on the .json file as first argument.
> 
> The old syntax is still supported, but deprecated.
> 
> 
> Diffs
> -----
> 
>   tests/kservicetojsontest/CMakeLists.txt 7f866e4 
>   KF5ServiceMacros.cmake 694b899 
> 
> Diff: https://git.reviewboard.kde.org/r/115336/diff/
> 
> 
> Testing
> -------
> 
> Tested with cmake master as well as cmake 2.8.12. Rebuilt kde-workspace with half of the calls to kservice_desktop_to_json using the new syntax and the rest using the old one.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/d190035e/attachment-0001.html>