Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

Alex Merry kde at randomguy3.me.uk
Fri Jan 31 18:33:14 UTC 2014



> On Jan. 27, 2014, 7:39 a.m., Kevin Ottens wrote:
> > src/doxygen-preprocess-kcfg.sh, line 5
> > <https://git.reviewboard.kde.org/r/114989/diff/1/?file=233879#file233879line5>
> >
> >     Should indeed just say kconfig_compiler.

Any progress on this?  As Kévin said, the $kcfg_compiler variable should just be replaced with kconfig_compiler directly (and we assume $PATH is set correctly).

Not that this script is used currently, but it may as well be correct.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114989/#review48344
-----------------------------------------------------------


On Jan. 12, 2014, 8:08 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114989/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references
> 
> 
> Diffs
> -----
> 
>   src/doxygen-preprocess-kcfg.sh 567a248 
> 
> Diff: https://git.reviewboard.kde.org/r/114989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/c1d45de6/attachment.html>


More information about the Kde-frameworks-devel mailing list