Review Request 115404: Improve dependencies
Michael Palimaka
kensington at gentoo.org
Fri Jan 31 14:48:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 2:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kemoticons
Description
-------
- Remove transitive dependencies as per mailing list
- Add missing KF5Config dependency
- QtGui is used rather than QtWidgets by the framework.
- QtWidgets is only used for tests
Diffs
-----
tests/CMakeLists.txt a3016c172f18559a98771c9d7da53cfdc758adad
src/core/CMakeLists.txt 9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483
KF5EmoticonsConfig.cmake.in 9b0efbc99cfed73c13e49c940cd5607afba85f07
CMakeLists.txt a48d111c59aa42d5b0b85aa959e5cf10e7b974b0
Diff: https://git.reviewboard.kde.org/r/115404/diff/
Testing
-------
Builds. Inspected source to verify changes.
Thanks,
Michael Palimaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/41fa563a/attachment.html>
More information about the Kde-frameworks-devel
mailing list