Review Request 115412: Fix linking against KWindowSystem

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115412/#review48676
-----------------------------------------------------------

Ship it!


Looks valid to me

- Martin Gräßlin


On Jan. 31, 2014, 1:49 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115412/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 1:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Fix linking against KWindowSystem
> 
> KWindowSystem uses QtWidgets classes in its API, so this should both be
> a PUBLIC link and should be a dependency in KF5WindowSystemConfig.cmake.
> 
> 
> Diffs
> -----
> 
>   KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 
>   src/CMakeLists.txt 39783988a292cb0dc62e3de91421e36930821fe2 
> 
> Diff: https://git.reviewboard.kde.org/r/115412/diff/
> 
> 
> Testing
> -------
> 
> KCrash did not previously build (with CMake 2.8.12.0), but does now.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/186fce4b/attachment.html>