Review Request 115255: Add x11 platform detection to kkeyserver_x11

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48624
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Jan. 27, 2014, 8:37 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115255/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 8:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add x11 platform detection to kkeyserver_x11
> 
> Just because it's only compiled for X11 doesn't mean it's running on
> X11. So before we go into code paths which call into X11 we should
> verify. That's better than:
> "QX11Info::display() returns 0.  I'm probably going to crash now."
> 
> Not adjusted are obvious X11 methods which take an XLib or xcb data
> type. If one calls those from non-x11 unconditionally it's an
> application bug and the application deserves to crash :-P
> 
> 
> Diffs
> -----
> 
>   src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 
> 
> Diff: https://git.reviewboard.kde.org/r/115255/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140130/9160fe37/attachment.html>