Review Request 115372: Improve the compiler version checks

Alex Merry kde at randomguy3.me.uk
Wed Jan 29 17:25:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115372/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 5:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Improve the compiler version checks

- Only warn if the compiler is not recent enough (it may still work...)
- Bump up the GCC version to 4.5 (on Linux, at least) to match Qt
- Add checks for Windows (both MSVC and MinGW)
- Add check for Clang


Diffs
-----

  kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 

Diff: https://git.reviewboard.kde.org/r/115372/diff/


Testing
-------

Built KCoreAddons with gcc 4.8.2 on Linux.  Got no warning.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/f7b1c9a8/attachment.html>


More information about the Kde-frameworks-devel mailing list