Review Request 115382: Remove unused dependencies
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Jan 29 15:45:03 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115382/#review48548
-----------------------------------------------------------
Ship it!
Cool :)
- Aleix Pol Gonzalez
On Jan. 29, 2014, 3:33 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115382/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 3:33 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kcrash
>
>
> Description
> -------
>
> QtGui is not used anywhere, and QtWidgets are only required for tests.
>
>
> Diffs
> -----
>
> src/kcrash.cpp b8e13a92c822d0bec47280941e7d5dadca5bfb38
> src/CMakeLists.txt 69dd376a0f08909d77b70c492fc60a5ab5220317
> CMakeLists.txt 0ce523b9a5355813285c508fcff8f4c6b80405ba
> KF5CrashConfig.cmake.in f1e6ecfee32f4c54d467f9a08976472c16fe6823
> autotests/CMakeLists.txt b01a5753adb0a3097b315570231edfbff30f89d7
>
> Diff: https://git.reviewboard.kde.org/r/115382/diff/
>
>
> Testing
> -------
>
> Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/2feb3b18/attachment.html>
More information about the Kde-frameworks-devel
mailing list