Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115378/#review48547
-----------------------------------------------------------


Looks good, but I can't test it right now.



kde-modules/KDECompilerSettings.cmake
<https://git.reviewboard.kde.org/r/115378/#comment34310>

    if(MSVC) is used everywhere else


- Andrius da Costa Ribas


On Jan. 29, 2014, 1:39 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115378/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 1:39 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Resolve some FIXMEs related to MSVC and Intel
> 
> In particular, MSVC (and Intel on Windows) have no equivalent of the
> -std flag to set the language standard, and Intel does not appear to
> produce the warnings that were disabled for MSVC.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 
> 
> Diff: https://git.reviewboard.kde.org/r/115378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/fa316e7d/attachment.html>