Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 3:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.


Repository: extra-cmake-modules


Description
-------

When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file} COMPILEFLAGS) set flags to "NOTFOUND". Leading to interesting build failures in kde-runtime when we then set flags to "NOTFOUND -fexceptions", see http://build.kde.org/job/kde-runtime_frameworks_qt5/58/


Diffs
-----

  kde-modules/KDECompilerSettings.cmake 6b7ab4e 

Diff: https://git.reviewboard.kde.org/r/115376/diff/


Testing
-------

Built kde-runtime successfully.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/2f638082/attachment.html>