Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
Alex Merry
kde at randomguy3.me.uk
Wed Jan 29 13:30:18 UTC 2014
> On Jan. 29, 2014, 12:59 p.m., Aleix Pol Gonzalez wrote:
> > Why would it be NOTFOUND?
Because CMake has a tendency to use NOTFOUND as an explicit "it wasn't just empty, it actually couldn't be found" value.
It evaluates that value as FALSE, incidentally.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/#review48528
-----------------------------------------------------------
On Jan. 29, 2014, 10:17 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115376/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 10:17 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file} COMPILEFLAGS) set flags to "NOTFOUND". Leading to interesting build failures in kde-runtime when we then set flags to "NOTFOUND -fexceptions", see http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake 6b7ab4e
>
> Diff: https://git.reviewboard.kde.org/r/115376/diff/
>
>
> Testing
> -------
>
> Built kde-runtime successfully.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/3746bda5/attachment.html>
More information about the Kde-frameworks-devel
mailing list