Review Request 115372: Improve the compiler version checks

Alex Merry kde at randomguy3.me.uk
Wed Jan 29 13:13:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115372/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 1:13 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

Reorganised by compiler type instead of by platform.  Added check for clang 3.1, and a warning if the compiler is not recognized.


Summary (updated)
-----------------

Improve the compiler version checks


Repository: extra-cmake-modules


Description (updated)
-------

Improve the compiler version checks

- Only warn if the compiler is not recent enough (it may still work...)
- Bump up the GCC version to 4.5 (on Linux, at least) to match Qt
- Add checks for Windows (both MSVC and MinGW)
- Add check for Clang


Diffs (updated)
-----

  kde-modules/KDECompilerSettings.cmake a4683b04459a2dca1bc5daab0c69c06acbf33ce0 

Diff: https://git.reviewboard.kde.org/r/115372/diff/


Testing
-------

Built KCoreAddons with gcc 4.8.2 on Linux.  Got no warning.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/3b83f173/attachment.html>


More information about the Kde-frameworks-devel mailing list