Review Request 115360: Remove the allocator and visibility check

David Faure faure at kde.org
Wed Jan 29 08:11:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115360/#review48514
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Jan. 28, 2014, 10:43 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115360/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 10:43 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove the allocator and visibility check
> 
> I am reasonably sure the allocator check is out of date, given our
> minimum GCC version, and it was not used for anything interesting
> anyway.
> 
> The visibility check will not be performed in practice, as this file
> will almost always be included before any check for Qt.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 
> 
> Diff: https://git.reviewboard.kde.org/r/115360/diff/
> 
> 
> Testing
> -------
> 
> Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/a838cf6f/attachment.html>


More information about the Kde-frameworks-devel mailing list