Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)
Alexander Richardson
arichardson.kde at googlemail.com
Wed Jan 29 01:34:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115372/#review48508
-----------------------------------------------------------
kde-modules/KDECompilerSettings.cmake
<https://git.reviewboard.kde.org/r/115372/#comment34292>
3.1 is the minimum clang Version according to https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11
- Alexander Richardson
On Jan. 29, 2014, 12:22 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115372/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 12:22 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Improve the compiler version checks
>
> - Only warn if the compiler is not recent enough (it may still work...)
> - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt
> - Add checks for Windows (both MSVC and MinGW) that match Qt
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake a4683b04459a2dca1bc5daab0c69c06acbf33ce0
>
> Diff: https://git.reviewboard.kde.org/r/115372/diff/
>
>
> Testing
> -------
>
> Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/43a68905/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list