Review Request 115367: Add a cmake option controlling whether to build kwalletd
Valentin Rusu
kde at rusu.info
Tue Jan 28 22:36:01 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115367/#review48500
-----------------------------------------------------------
Ship it!
Ship It!
- Valentin Rusu
On Jan. 28, 2014, 10:28 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115367/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 10:28 p.m.)
>
>
> Review request for KDE Frameworks and Valentin Rusu.
>
>
> Repository: kwallet-framework
>
>
> Description
> -------
>
> Add a cmake option controlling whether to build kwalletd
>
> This is better than a random variable that needs defining: it is stored
> in the cache, and it gets a help text. It can now be set using `make
> edit_cache` or when building with ccmake.
>
>
> Diffs
> -----
>
> CMakeLists.txt d5e7c5e98b4ce84877e3a69dda0091059453985b
> README.md fdc05261f8af8f8285b35af78589cb43bab7f28d
> src/runtime/CMakeLists.txt 7bfad97c55e80a9828564a6803074289a66ff04b
> tests/CMakeLists.txt 41e09eec8bef54c7e28ff6c55629d2e6179abdc7
>
> Diff: https://git.reviewboard.kde.org/r/115367/diff/
>
>
> Testing
> -------
>
> Builds whether the option is on or off; kwalletd is built only if the option is on.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140128/b1da8585/attachment.html>
More information about the Kde-frameworks-devel
mailing list