Review Request 115367: Add a cmake option controlling whether to build kwalletd

Valentin Rusu kde at rusu.info
Tue Jan 28 21:38:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115367/#review48499
-----------------------------------------------------------



src/runtime/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115367/#comment34291>

    Please apply this option also in tests/CMakeLists.txt


- Valentin Rusu


On Jan. 28, 2014, 8:40 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115367/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 8:40 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet-framework
> 
> 
> Description
> -------
> 
> Add a cmake option controlling whether to build kwalletd
> 
> This is better than a random variable that needs defining: it is stored
> in the cache, and it gets a help text.  It can now be set using `make
> edit_cache` or when building with ccmake.
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt 7bfad97c55e80a9828564a6803074289a66ff04b 
> 
> Diff: https://git.reviewboard.kde.org/r/115367/diff/
> 
> 
> Testing
> -------
> 
> Builds whether the option is on or off; kwalletd is built only if the option is on.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140128/b36b5b4c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list