Review Request 115353: Rename dbus interface files for solid

Stefano Avallone stavallo at unina.it
Tue Jan 28 14:12:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115353/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 2:12 p.m.)


Review request for KDE Frameworks.


Repository: solid


Description (updated)
-------

The dbus interface files installed by solid conflict with those installed by kdelib4. To allow co-installability of kde4 and kf5, rename the former by using the same approach adopted for kglobalaccess, kjobviewer, etc.

If this patch seems reasonable, I will submit the companion patch for kde-workspace.


Diffs
-----

  src/solid/CMakeLists.txt 84c254e 

Diff: https://git.reviewboard.kde.org/r/115353/diff/


Testing
-------

Builds and installs fine. I am not an expert of dbus interface files and cmake, so please check that this patch does not produce unwanted side-effects.


Thanks,

Stefano Avallone

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140128/a74360d8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list