Review Request 115209: Fix KDoctools build on Windows

[Alexander Richardson]

> On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 150
> > <https://git.reviewboard.kde.org/r/115209/diff/2/?file=235239#file235239line150>
> >
> >     I think you swapped the code for the two conditions (the part with 'cmd /k' should be inside if (WIN32) I guess

You're right. I fixed it locally, but forgot to update the review request


> On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote:
> > src/meinproc_common.cpp, line 11
> > <https://git.reviewboard.kde.org/r/115209/diff/2/?file=235241#file235241line11>
> >
> >     For changes like this and the other #define later I would like to have an opinion from kdewin group

According to http://msdn.microsoft.com/en-us/library/96ayss4b.aspx the _popen + pclose should be fine (as long as it is a non-gui executable, but that has been achieved by ecm_mark_nongui_executable).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review48427
-----------------------------------------------------------


On Jan. 22, 2014, 4:12 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115209/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 4:12 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Two separate commits: 
> 
> -----------------------------------
> 
> Print a message when a file is not found
> 
> This way meinproc no longer fails silently
> 
> ----------------------------------
> 
> Allow compiling on Windows with MSVC
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 
>   src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b 
>   src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 
>   src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade 
>   src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 
> 
> Diff: https://git.reviewboard.kde.org/r/115209/diff/
> 
> 
> Testing
> -------
> 
> Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/f9d5b120/attachment-0001.html>