Review Request 115345: Fix kimageformats build with MSVC
Alex Merry
kde at randomguy3.me.uk
Mon Jan 27 22:36:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
-----------------------------------------------------------
Just ran a quick test, using the imageconverter tool in the tests/ directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then did the same after patching with patched.pcx and patched.pic. Then
cmp orig.pcx patched.pcx
is fine, but
cmp orig.pic patched.pic
orig.pic patched.pic differ: byte 93, line 1
So something has gone wrong :-)
- Alex Merry
On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115345/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 9:38 p.m.)
>
>
> Review request for KDE Frameworks, kdewin and Alex Merry.
>
>
> Repository: kimageformats
>
>
> Description
> -------
>
> 1) Use #pragma pack instead of __attribute__((packed))
>
> This is available on all supported compilers, the attribute does not exist
> for MSVC
> --------------------------------------------------
> 2) Use q{To,From}BigEndian instead of hton* and ntoh*
>
> These functions don't seem to be available as inline functions on win32
>
>
> Diffs
> -----
>
> src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
> src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
> src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
>
> Diff: https://git.reviewboard.kde.org/r/115345/diff/
>
>
> Testing
> -------
>
> didn't compile before, does now
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/4d9f34c7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list