Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/
-----------------------------------------------------------

Review request for KDE Frameworks and kdewin.


Repository: kunitconversion


Description
-------

With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

Is it okay to put the define in the source file, or should I rather put it in the CMake code?


Diffs
-----

  src/angle.cpp 4df1981930e6459a7d2486caffaee6fd439976d0 

Diff: https://git.reviewboard.kde.org/r/115344/diff/


Testing
-------

didn't compile before, does now


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/477c4d79/attachment-0001.html>